RFR 7032154: Performance tuning of sun.misc.FloatingDecimal/FormattedFloatingDecimal (original) (raw)

Martin Buchholz martinrb at google.com
Wed May 29 23:57:42 UTC 2013

I would like to see the real world-class experts on this scary math stuff (Alan Eliasen, Tim Buktu) be made honorary jdk reviewers, just for their area of specialization, if that was bureaucratically possible. Shouldn't the original authors be cc'ed?

The code is awesome. My thorough review found only these defects:

Use third person in the first sentence of a javadoc - e.g. s/Retrieve/Retrieves/.

Don't use the denigrated C style char zero[] = Instead use char[] zero =

This looks odd:

normalized as a//binary*

The original comment looked more normal:

normalized as a binary

Otherwise, approved!

On Fri, May 24, 2013 at 10:09 AM, Brian Burkhalter < brian.burkhalter at oracle.com> wrote:

Originally posted one month ago today.

http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-April/016355.html https://www.youtube.com/watch?v=D9kvV5lhiE Thanks, Brian

More information about the core-libs-dev mailing list