RFR (jaxp): review backport to jdk7u-dev of 8008738 (original) (raw)

RFR (jaxp): review backport to jdk7u-dev of 8008738 - Issue in com.sun.org.apache.xml.internal.serializer.Encodings causes some JCK tests to fail intermittently

huizhe wang huizhe.wang at oracle.com
Thu May 30 16:52:07 UTC 2013

Hi Daniel,

This looks good. Thanks again for the extra effort to keep JDK7 updated.

-Joe

On 5/30/2013 1:59 AM, Daniel Fuchs wrote:

Hi,

This is a request for review to backport the changes for: <https://jbs.oracle.com/bugs/browse/JDK-8008738> to jdk7u-dev. The changeset for jdk7u-dev only slightly differs from that for jdk 8, on these two counts: 1. JAXP needs to be compiled with the bootstrap JDK - which means that JAXP in jdk 7 cannot depend on new jdk 7 APIs. In Encodings.java I had to replace a try-with-resource by a try-finally. 2. The jdk/test/Makefile needed to be updated in order to add javax/xml/jaxp to the jdkother target. Here is the webrev for the changeset that was pushed in jdk8: http://cr.openjdk.java.net/~dfuchs/JDK-8008738/webrev.03/ Here is the altered webrev for jdk7u-dev: http://cr.openjdk.java.net/~dfuchs/JDK-8008738/webrev-jdk7u-dev.00/ Best regards, -- daniel The review for the original fix happened for jdk8 on the core-libs-dev list, in these two thread: <http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-April/016037.html> <http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-May/016602.html>

More information about the core-libs-dev mailing list