RFR: 8035618 : Four api/org_omg/CORBA TCK tests fail under plugin only (original) (raw)
Seán Coffey sean.coffey at oracle.com
Wed Apr 2 14:44:22 UTC 2014
- Previous message: RFR: 8035618 : Four api/org_omg/CORBA TCK tests fail under plugin only
- Next message: RFR: 8035618 : Four api/org_omg/CORBA TCK tests fail under plugin only
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 02/04/14 15:05, Alan Bateman wrote:
On 02/04/2014 11:42, Seán Coffey wrote:
I'm looking to port this fix from JDK 8 to 9. Other changes were made for JDK 9 given that we have access to the javaAwtAccess.getAppletContext() method when using JDK 8 as the boot strap JDK for CORBA. Direct access to the sun.awt.AppContect class has been removed.
bug : https://bugs.openjdk.java.net/browse/JDK-8035618 webrev : http://cr.openjdk.java.net/~coffeys/webrev.8035618.jdk9.v3/webrev/ This mostly looks okay to me except that pmContexts should be final. It looks like this code is also a candidate to use computeIfAbsent so you could replace L251-254 with one statement. I'll make pmContexts final before pushing. Thanks for the lambda tip. As per trial though, it looks like CORBA code is still compiled with -source 1.7, we can revisit after this changes.
regards, Sean.
-Alan.
- Previous message: RFR: 8035618 : Four api/org_omg/CORBA TCK tests fail under plugin only
- Next message: RFR: 8035618 : Four api/org_omg/CORBA TCK tests fail under plugin only
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]