RFR [8038982]: java/lang/ref/EarlyTimeout.java failed again (original) (raw)
Ivan Gerasimov ivan.gerasimov at oracle.com
Mon Apr 14 13:21:58 UTC 2014
- Previous message: RFR [8009637]: Some error messages are missing a space
- Next message: RFR [8038982]: java/lang/ref/EarlyTimeout.java failed again
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hello!
The test EarlyTimeout.java failed again, now with message "elapsed time 981 is less than timeout 1000."
The root cause seems to be non-accurate time measurement in Windows: http://msdn.microsoft.com/en-us/library/windows/desktop/ms724397(v=vs.85).aspx
Because of this we can achieve this result: long start1 = System.currentTimeMillis(); long start2 = System.nanoTime();
~~~~~~~~ long elapsed2 = (System.nanoTime() - start2) / 1000000; long elapsed1 = System.currentTimeMillis() - start1;
assert elapsed2 < elapsed1; // can fail
There might be two ways to address the issue:
- add a tolerance > 15 ms, or
- use System.nanoTime() for the measurement.
I did both.
Would you please help review the test fix?
BUGURL: https://bugs.openjdk.java.net/browse/JDK-8038982 WEBREV: http://cr.openjdk.java.net/~igerasim/8038982/0/webrev/
Sincerely yours, Ivan
- Previous message: RFR [8009637]: Some error messages are missing a space
- Next message: RFR [8038982]: java/lang/ref/EarlyTimeout.java failed again
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]