RFR [8040806]: BitSet.toString() can throw IndexOutOfBoundsException (original) (raw)
Ivan Gerasimov ivan.gerasimov at oracle.com
Thu Apr 24 09:44:24 UTC 2014
- Previous message: RFR [8040806]: BitSet.toString() can throw IndexOutOfBoundsException
- Next message: Review request: 8040059 Change default policy for extensions to no permission
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Thanks Peter!
The test was designed to be laconic, so I tried to keep it this way. I can, of course, include the mentioning of the exception in the message. With the bug fixed it's not going to be shown anyway :)
Sincerely yours, Ivan
On 24.04.2014 11:24, Peter Levart wrote:
Hi Ivan,
This fix could be called: Leaving on the edge - A tricky game of overflows :-) I think the fix is good. In the test it would be nice to include the IndexOutOfBoundsException in the failure message to ease debugging. Regards, Peter On 04/22/2014 02:13 PM, Ivan Gerasimov wrote: Hello!
If a BitSet has the bit Integer.MAXVALUE set, then calling toString() will throw an exception. The same thing happens if the bit (Integer.MAXVALUE-1) is set. Would you please help review the fix for this issue? BUGURL: https://bugs.openjdk.java.net/browse/JDK-8040806 WEBREV: http://cr.openjdk.java.net/~igerasim/8040806/0/webrev/ Sincerely yours, Ivan
- Previous message: RFR [8040806]: BitSet.toString() can throw IndexOutOfBoundsException
- Next message: Review request: 8040059 Change default policy for extensions to no permission
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]