RFR [8035975] Pattern.compile(String, int) fails to throw IllegalArgumentException (original) (raw)
Ivan Gerasimov ivan.gerasimov at oracle.com
Mon Jul 7 19:25:32 UTC 2014
- Previous message: RFR [8035975] Pattern.compile(String, int) fails to throw IllegalArgumentException
- Next message: RFR [8035975] Pattern.compile(String, int) fails to throw IllegalArgumentException
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Thanks you Sherman for review!
On 07.07.2014 21:38, Xueming Shen wrote:
On 07/07/2014 10:07 AM, Ivan Gerasimov wrote:
Hello!
The javadoc says that Pattern.compile(String regex, int flag) will throw IllegalArgumentException, if flag contains an invalid bit set. However, it fails to do so. Would you please help review the simple fix for that? Alternatively, we could just remove the corresponding @throws part, but that would change the spec. BUGURL: https://bugs.openjdk.java.net/browse/JDK-8035975 WEBREV: http://cr.openjdk.java.net/~igerasim/8035975/0/webrev/ Sincerely yours, Ivan Looks fine. But given it's a behavior change, you probably still need a CCC for it. Okay, just filed one.
Sincerely yours, Ivan
thanks! -Sherman
- Previous message: RFR [8035975] Pattern.compile(String, int) fails to throw IllegalArgumentException
- Next message: RFR [8035975] Pattern.compile(String, int) fails to throw IllegalArgumentException
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]