RFR 8044047: Missing null pointer checks for streams (original) (raw)

Daniel Fuchs daniel.fuchs at oracle.com
Tue Jul 15 10:38:19 UTC 2014

On 7/15/14 9:35 AM, Paul Sandoz wrote:

Ping..

http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-July/027508.html Paul.

Hi Paul,

This is not my area of expertise - but I haven't seen anything wrong.

However - I applied your patch and ran the tests locally on my machine, and I saw that jdk/test/java/util/stream/test/org/openjdk/tests/java/util/stream/FlatMapOpTest.java was intermittently failing in timeout (e.g. while I was compiling another JDK in another workspace).

So I wonder whether something should be done for this test to reduce the risk of seeing it timing out on slow machines?

best regards,

-- daniel

On Jul 2, 2014, at 2:01 PM, Paul Sandoz <Paul.Sandoz at oracle.com> wrote:

Hi,

Please review this fix for some missing null-checks in stream code: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8044047-null-checks/webrev/ https://bugs.openjdk.java.net/browse/JDK-8044047 I also boosted some of the primitive summary statistic tests. Unfortunately the refactoring of some test names resulted in disassociation between old and new (not quite sure why in this case), so diffs for renamed tests are below. Paul.

More information about the core-libs-dev mailing list