RFR(XS): 8050825: Support running regression tests using jtreg_tests+TESTDIRS from top level (original) (raw)

Mikael Vidstedt mikael.vidstedt at oracle.com
Wed Jul 16 03:22:31 UTC 2014

On 2014-07-15 20:04, Mike Duigou wrote:

This looks like a nice improvement and provides a good way to execute specific sub-sets that are smaller than the TEST.groups definitions.

I'd like to hook it up to the top level make as an alternative to the current recipe. make test TEST="jdkcore" Perhaps adjust the top level make test target so that it invokes the test makefile with both the contents of TEST and TESTDIRS as two separate executions?

This sounds like a very reasonable follow-up!

Thanks for the review.

Cheers, Mikael

Mike On Jul 15 2014, at 19:51 , Mikael Vidstedt <mikael.vidstedt at oracle.com> wrote:

I suppose a webrev helps:

http://cr.openjdk.java.net/~mikael/webrevs/8050825/webrev.00/webrev/ Sorry 'bout that. Cheers, Mikael On 2014-07-15 19:48, Mikael Vidstedt wrote: Please review the below change which adds support for running jtreg tests from the top level test/ directory using the 'make TESTDIRS= jtregtests' syntax. The TESTDIRS syntax is already used in files like hotspot/test/Makefile and jdk/test/Makefile and allows for selecting which jtreg tests to run by providing a directory/path filter. The change enables doing the same type of invocation from the top level; something like this:

cd test && make TESTDIRS=../hotspot/test/runtime jtregtests cd test && make TESTDIRS=../jdk/test/javax jtregtests The implementation logic simply extracts the component (hotspot, jdk etc.) from the value of TESTDIRS and delegates to the respective component's test/Makefile, removing the ..//test from TESTDIRS in the process. Thanks, Mikael

More information about the core-libs-dev mailing list