RFR [8051382] Optimize java.lang.reflect.Modifier.toString() (original) (raw)
Martin Buchholz martinrb at google.com
Fri Jul 18 22:53:08 UTC 2014
- Previous message: RFR [8051382] Optimize java.lang.reflect.Modifier.toString()
- Next message: RFR [8051382] Optimize java.lang.reflect.Modifier.toString()
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
It looks like the test has a new import, but no actual new code that uses it.
On Fri, Jul 18, 2014 at 3:39 PM, Ivan Gerasimov <ivan.gerasimov at oracle.com> wrote:
Hello!
StringBuilder can be replaced with StringJoiner, which will make the code shorter and, probably, more efficient. The existing regtest (java/lang/reflect/Modifier/toStringTest.java) can be used to make sure nothing is broken. Would you please help review the fix? BUGURL: https://bugs.openjdk.java.net/browse/JDK-8051382 WEBREV: http://cr.openjdk.java.net/~igerasim/8051382/0/webrev/ Sincerely yours, Ivan
- Previous message: RFR [8051382] Optimize java.lang.reflect.Modifier.toString()
- Next message: RFR [8051382] Optimize java.lang.reflect.Modifier.toString()
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]