RFR JDK-8051422: Remove JNDI dependency on java.applet.Applet (original) (raw)

Chris Hegarty chris.hegarty at oracle.com
Mon Jul 28 15:24:30 UTC 2014

Thanks Pavel. Reviewed.

-Chris.

On 28/07/14 16:11, Pavel Rappo wrote:

Well spotted, Chris! Here's the updated webrev which fixes that misunderstanding (see test "AppletIsNotUsed"):

http://cr.openjdk.java.net/~prappo/8051422/webrev.01/ Thanks, -Pavel On 28 Jul 2014, at 15:37, Chris Hegarty <chris.hegarty at oracle.com> wrote:

Pavel,

The implementation changes look fine. It is surprising too see that NoApplet now succeeds to create the InitialContext, which made to take another look at the code. So the context can still be created, and it will throw an Exception on first use, lookup, etc. Maybe it is worth expanding the test a little to cover this? -Chris. On 28/07/14 14:45, Alan Bateman wrote: On 28/07/2014 11:04, Pavel Rappo wrote: Hi everyone,

Could you please review my change for JDK-8051422? http://cr.openjdk.java.net/~prappo/8051422/webrev.00/ -Pavel JDK-8049270 was the original issue tracking this, I guess we should close this as a dup now and move the labels. In any case, the changes look good to me and it looks like you've caught everything. Minor comment is that I don't think you see the "see JDK-8051986" in CorbaUtils. In the NoApplet test then you've replaced the copyright date. -Alan.

More information about the core-libs-dev mailing list