RFR: 8044671: NPE from JapaneseEra when a new era is defined in calendar.properties (original) (raw)
Masayoshi Okutsu masayoshi.okutsu at oracle.com
Wed Jul 30 23:27:43 UTC 2014
- Previous message: RFR: 8044671: NPE from JapaneseEra when a new era is defined in calendar.properties
- Next message: RFR: 8044671: NPE from JapaneseEra when a new era is defined in calendar.properties
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
The copyright year range should be updated. Otherwise, the fix looks good to me.
Masayoshi
On 7/23/2014 11:51 PM, dmeetry degrave wrote:
Hello,
Please review a simple fix (jdk 8 and 9) for 8044671: NPE from JapaneseEra when a new era is defined in calendar.properties bug: https://bugs.openjdk.java.net/browse/JDK-8044671 fix: http://cr.openjdk.java.net/~dmeetry/8044671/webrev.01 No automated regression test, unfortunately, it would require to modify "private static final Era[] eras;" in java/util/JapaneseImperialCalendar.java, though it's easy to test it by calling 'JapaneseDate date = JapaneseDate.of(2100,1,1);' with a new era added via JAVAHOME/jre/lib/calendars.properties (test and calendars.properties are attached to the bug). thanks, dmeetry
- Previous message: RFR: 8044671: NPE from JapaneseEra when a new era is defined in calendar.properties
- Next message: RFR: 8044671: NPE from JapaneseEra when a new era is defined in calendar.properties
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]