RFR: 8047721: @since should have JDK version (original) (raw)

Henry Jen henry.jen at oracle.com
Fri Jun 20 20:42:43 UTC 2014

I assume the reason to have those @since JCE tag is somehow we want to distinguish those APIs from the rest, thus I chose to preserve them.

If we agree it's not worth to keep, I can remove them.

Cheers, Henry

On 06/20/2014 01:25 PM, Joe Darcy wrote:

Hi Henry,

For the Cipher{Input, Output}Stream classes, the class itself was added in 1.4 so it seems redundant to have the @since information on each method too. In other words, is preserving the @since JCE 1.2 information useful at this point? Thanmks, -Joe On 06/20/2014 01:20 PM, Henry Jen wrote: You are absolutely right, I should have fixed it as I did for the rest.

Updated webrev can be found at http://cr.openjdk.java.net/~henryjen/jdk9/8047721/1/webrev/ Cheers, Henry On 06/20/2014 01:01 PM, Paul Benedict wrote: Henry,

I think "JCE1.2" should get the space to be "JCE 1.2" so it matches other secondary versions like "JNDI 1.1" (last part of your patch). Or, you could make that another cleanup in itself. Cheers, Paul

More information about the core-libs-dev mailing list