Long valueOf instead of new Long (original) (raw)
Andrej Golovnin andrej.golovnin at gmail.com
Fri Jun 27 10:36:19 UTC 2014
- Previous message: Long valueOf instead of new Long
- Next message: Long valueOf instead of new Long
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Pavel,
the both web revs looks identical to me. Here is what I have found so far in the webrev.01:
in src/share/classes/com/sun/security/auth/SolarisNumericGroupPrincipal.java:
@@ -108,11 +108,11 @@ * @param primaryGroup true if the specified GID represents the * primary group to which this user belongs. * */ public SolarisNumericGroupPrincipal(long name, boolean primaryGroup) {
this.name = (new Long(name)).toString();
}this.name = Long.valueOf(name).toString(); this.primaryGroup = primaryGroup;
It is better to use Long.toString(long):
this.name = Long.toString(name);
This also applies to:
src/share/classes/com/sun/security/auth/SolarisNumericUserPrincipal.java src/share/classes/com/sun/security/auth/UnixNumericGroupPrincipal.java src/share/classes/com/sun/security/auth/UnixNumericUserPrincipal.java
@@ -94,11 +94,11 @@ * * @param name the user identification number (UID) for this user * represented as a long. */ public SolarisNumericUserPrincipal(long name) {
this.name = (new Long(name)).toString();
}this.name = Long.valueOf(name).toString();
In src/share/classes/javax/management/modelmbean/RequiredModelMBean.java:
@@ -542,11 +542,11 @@ RequiredModelMBean.class.getName(), mth,"currencyTimeLimit: " + expTime); }
// convert seconds to milliseconds for time comparisoncurrencyPeriod = ((new Long(expTime)).longValue()) * 1000;
currencyPeriod = ((Long.valueOf(expTime)).longValue()) * 1000;
Please use Long.parseLong(String), e.g.:
currencyPeriod = Long.parseLong(expTime) * 1000;
And here please use Long.parseLong8String) too:
@@ -578,11 +578,11 @@ }
if (tStamp == null)
tStamp = "0";long lastTime = (new Long(tStamp)).longValue();
long lastTime = (Long.valueOf(tStamp)).longValue();
e.g.:
long lastTime = Long.parseLong(tStamp);
In src/share/classes/sun/security/jgss/wrapper/GSSNameElement.java
@@ -201,11 +201,11 @@ return false; } }
public int hashCode() {return new Long(pName).hashCode();
}return Long.valueOf(pName).hashCode();
The method Long.hashCode(long) (added in JDK 8) should be used to calculate the hash for a long value, e.g.:
return Long.hashCode(pName);
Best regards, Andrej Golovnin
On Fri, Jun 27, 2014 at 12:00 PM, Pavel Rappo <pavel.rappo at oracle.com> wrote:
I created an issue to track the progress and also made 2 webrevs. One for the original patch and one for the changes that have been suggested earlier in this thread by Paul and Andrej. Here we go:
https://bugs.openjdk.java.net/browse/JDK-8048267 http://cr.openjdk.java.net/~prappo/8048267/webrev.00 http://cr.openjdk.java.net/~prappo/8048267/webrev.01 -Pavel On 26 Jun 2014, at 10:58, Chris Hegarty <chris.hegarty at oracle.com> wrote: > Otavio, > > I skimmed over the patches and they look ok to me. I think they would be suitable for inclusion in jdk9/dev. > > -Chris. > > P.S. I do not currently have time to sponsor this, but I cc’ed Pavel who may be able to help get his in. > > On 14 Jun 2014, at 14:46, Otávio Gonçalves de Santana <_ _otaviojava at java.net> wrote: > >> Reason: The Long class has cache and using it, will save memory and will >> faster than using create new instance of Long. >> >> webrev: >> https://dl.dropboxusercontent.com/u/16109193/openjdk/longvalueof.zip >> >> similar: https://bugs.openjdk.java.net/browse/JDK-8044461 >> -- >> Otávio Gonçalves de Santana >> >> blog: http://otaviosantana.blogspot.com.br/ >> twitter: http://twitter.com/otaviojava >> site: http://www.otaviojava.com.br >> (11) 98255-3513 >> <suntools.diff><sunsecurity.diff><sunnio.diff><sunmanagement.diff><sunjvmstat.diff><javaxswing.diff><javax-management.diff><javatext.diff><javaawtimage.diff><internalorgobjectweb.diff><comsuntools.diff><comsunsecurity.diff><comsunjmxsnmp.diff><comsunjdnildap.diff><comsunimageio.diff> >
- Previous message: Long valueOf instead of new Long
- Next message: Long valueOf instead of new Long
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]