[9] Request for Review: 8048337: Examine if macosx/bundle/JavaAppLauncher and JavaAppLauncher.java can be removed (original) (raw)

Mandy Chung mandy.chung at oracle.com
Fri Jun 27 17:30:54 UTC 2014

Hi Dave,

On 6/27/2014 9:31 AM, David DeHaven wrote:

As the subject says, so examined and determined that it can indeed be removed.

Good to see unused code be removed from the repo!

The Java source was being built and included in rt.jar, but it would not run because jdk/src/macosx/native/apple/launcher/JavaAppLauncher.m (implementing the two native methods) was not being built so it would have died with an UnsatisfiedLinkError. The Xcode project is not referenced anywhere in any makefile I looked at.

I found JavaAppLauncher.o in $BUILD_OUTPUTDIR/jdk/libosx directory (see the symbols below). On the other hand, appLauncherErrors.properties is needed by JavaAppLauncher but not included in the JDK image. MissingResourceException would be thrown and such exception should have been noticed if JavaAppLauncher is used.

As you suggest in another thread, Java packager is a better option.

Since it's not used anywhere (and appears to never have been used at all?), it should be purged from the jdk source.

JBS issue: https://bugs.openjdk.java.net/browse/JDK-8048337 Webrev: http://cr.openjdk.java.net/~ddehaven/8048337/jdk.0/

Looks good.

Mandy

$ nm $OUTPUTDIR/jdk/objs/libosx/JavaAppLauncher.o | grep launcher

0000000000000000 T _Java_apple_launcher_JavaAppLauncher_nativeConvertAndRelease 0000000000004bb8 S _Java_apple_launcher_JavaAppLauncher_nativeConvertAndRelease.eh 00000000000000c6 T _Java_apple_launcher_JavaAppLauncher_nativeInvokeNonPublic 0000000000004bf8 S _Java_apple_launcher_JavaAppLauncher_nativeInvokeNonPublic.eh

More information about the core-libs-dev mailing list