RFR: JDK-8036603 - Check jdk/src/windows/native/java/lang/ProcessEnvironment_md.c for JNI pending exceptions (original) (raw)
Mark Sheppard mark.sheppard at oracle.com
Fri Mar 7 22:21:55 UTC 2014
- Previous message: RFR: JDK-8036603 - Check jdk/src/windows/native/java/lang/ProcessEnvironment_md.c for JNI pending exceptions
- Next message: RFR: JDK-8036603 - Check jdk/src/windows/native/java/lang/ProcessEnvironment_md.c for JNI pending exceptions
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Thanks Alan and Mandy for the feedback
I make the amendments as you both suggest
regards Mark
On 07/03/2014 21:34, Alan Bateman wrote:
On 07/03/2014 21:24, Mark Sheppard wrote:
Hi, Please oblige and review the changes http://cr.openjdk.java.net/~msheppar/8036603/webrev/ which address the issues raised in https://bugs.openjdk.java.net/browse/JDK-8036603 summary JNUClassString extracted as parameter to GetMethodID and NewObject calls and NULCHECKed Is it necessary to call JNUClassString twice? (just wondering if L65-66 can be removed). One suggestion for classformethod is to rename it to strclass as it might be a bit clearer. -Alan.
- Previous message: RFR: JDK-8036603 - Check jdk/src/windows/native/java/lang/ProcessEnvironment_md.c for JNI pending exceptions
- Next message: RFR: JDK-8036603 - Check jdk/src/windows/native/java/lang/ProcessEnvironment_md.c for JNI pending exceptions
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]