RFR: JDK-8036818: DateTimeFormatter withResolverFields() fails to accept null (original) (raw)
Stephen Colebourne scolebourne at joda.org
Wed Mar 12 10:45:11 UTC 2014
- Previous message: JDK 9 RFR of JDK-8037174: Fix serial lint warnings in sun.applet
- Next message: RFR: JDK-8036818: DateTimeFormatter withResolverFields() fails to accept null
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
This is a request for review of this bug: https://bugs.openjdk.java.net/browse/JDK-8036818
The method DateTimeFormatter withResolverFields() is supposed to accept null. This is to allow a coy of the formatter to be returned reset to the original state of having no resolver fields. The docs say: "@param resolverFields the new set of resolver fields, null if no fields" which was written to indicate that resetting to null is permitted.
The fix is to check for null and return a copy of the formatter. Note that there are two variations of the method which need fixing.
Proposed patch: https://gist.github.com/jodastephen/9395197 The patch includes no spec changes. The patch fixes the broken TCK tests.
I need a reviewer and a committer please. thanks Stephen
- Previous message: JDK 9 RFR of JDK-8037174: Fix serial lint warnings in sun.applet
- Next message: RFR: JDK-8036818: DateTimeFormatter withResolverFields() fails to accept null
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]