RFR: JDK-8035099 LocalTime with(MILLI_OF_DAY/MICRO_OF_DAY) incorrect (original) (raw)
Stephen Colebourne scolebourne at joda.org
Mon Mar 17 11🔞19 UTC 2014
- Previous message: RFR: JDK-8035099 LocalTime with(MILLI_OF_DAY/MICRO_OF_DAY) incorrect
- Next message: RFR: JDK-8035099 LocalTime with(MILLI_OF_DAY/MICRO_OF_DAY) incorrect
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
ping
On 12 March 2014 10:48, Stephen Colebourne <scolebourne at joda.org> wrote:
This is a request for review of this bug: https://bugs.openjdk.java.net/browse/JDK-8035099
The implementation for LocalTime with(MILLIOFDAY, n) and LocalTime with(MICROOFDAY, n) fails to match the specification. LocalTime base = LocalTime.of(12, 30, 40, 987654321); LocalTime result = base.with(MILLIOFDAY, 0); expected: 00:00:00.000000000 was: 00:00:00.000654321 LocalTime result = base.with(MICROOFDAY, 0); expected: 00:00:00.000000000 was: 00:00:00.000000321 The spec is clear in both cases - "This completely replaces the time and is equivalent to using {@link #ofNanoOfDay(long)}", thus this is clearly a bug.
Proposed patch: https://gist.github.com/jodastephen/9057131 The patch includes no spec changes. The patch includes new TCK tests that are derived explicitly from the spec. I need a reviewer and a committer please. thanks Stephen
- Previous message: RFR: JDK-8035099 LocalTime with(MILLI_OF_DAY/MICRO_OF_DAY) incorrect
- Next message: RFR: JDK-8035099 LocalTime with(MILLI_OF_DAY/MICRO_OF_DAY) incorrect
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]