RFR [6943190] TEST_BUG: java/lang/Runtime/exec/ExecWithInput.java hardcodes path to cat (original) (raw)

Martin Buchholz martinrb at google.com
Wed Mar 19 17:46:36 UTC 2014

Looks Good To Me!

On Wed, Mar 19, 2014 at 10:34 AM, Ivan Gerasimov <ivan.gerasimov at oracle.com>wrote:

Thanks Martin!

On 19.03.2014 20:23, Martin Buchholz wrote: I expected to see System.out used instead (not that it matters much).

I would write: System.out.println("'true' command not found; skipping test"); Two cases are mixed here: - normal run (OS does not have this command), - erroneous run (OS isn't configured correctly, so the command couldn't be find). I agree it's not matters much, so no problem to replace the output as you suggest. Here's the (final?) webrev: http://cr.openjdk.java.net/~igerasim/6943190/5/webrev/ Sincerely yours, Ivan

More information about the core-libs-dev mailing list