RFR: 8036786: Update jdk7 testlibrary to match jdk8 (original) (raw)
Staffan Larsen staffan.larsen at oracle.com
Tue Mar 25 10:17:24 UTC 2014
- Previous message: RFR: 8036786: Update jdk7 testlibrary to match jdk8
- Next message: Review 8035808: Eliminate dependency to GetPropertyAction and other sun.security.action convenient classes
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
I’ve looked at the changes in StreamPumper and ProcessTools: they look good.
Since the rest of the code is a straight backport, I didn’t look at it.
Reviewed.
Thanks, /Staffan
On 6 mar 2014, at 16:34, Vladimir Kempik <vladimir.kempik at oracle.com> wrote:
Please review this change to update jdk part of testlibrary in jdk7.
It updates testlibrary with new apis from jdk8's testlibrary. When porting jdk8's testlibrary to jdk7, I had to make few changes: 1) rewrite one lambda usage in StreamPumper.java to non-lambda version. 2) get rid of predicate functionality in ProcessTools.java: startProcess as it wasn't used anyway and unsupported in jdk7. Every test in open part of jdk that uses testlibrary still works after update (in fact there are 3 of them). Webrev: http://cr.openjdk.java.net/~vkempik/8036786/webrev.00/ Thanks, Vladimir.
- Previous message: RFR: 8036786: Update jdk7 testlibrary to match jdk8
- Next message: Review 8035808: Eliminate dependency to GetPropertyAction and other sun.security.action convenient classes
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]