RFR 8078645: removeIf(filter) in ConcurrentHashMap removes entries for which filter is false (original) (raw)

David Holmes david.holmes at oracle.com
Tue May 5 01:40:53 UTC 2015

Hi Paul,

On 5/05/2015 1:59 AM, Paul Sandoz wrote:

Hi

Please review: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8078645-ConcurrentMap-views-removeIf/webrev/ These updates are already in the 166 repo. The documentation update to the class of ConcurrentMap is going through CCC. I took the liberty of also cleaning up some smaller doc errors on ConcurrentMap as made in the 166 repo.

Functional changes look okay - I'll not comment on test.

One query in ConcurrentSkipListMap, we have:

2500 // else use iterator 2501 @SuppressWarnings("unchecked") Iterator<Map.Entry<Object,E>> it = 2502 ((SubMap<Object,E>)m).entryIterator();

and then

2578 // else use iterator 2579 Iterator<Map.Entry<K1,V1>> it = ((SubMap<K1,V1>)m).entryIterator();

why does only the former require the "unchecked" warning suppression?

Thanks, David

Thanks, Paul.

More information about the core-libs-dev mailing list