RFR: 8074657: Missing space on a boundary of concatenated strings (original) (raw)
Ivan Gerasimov ivan.gerasimov at oracle.com
Mon May 11 23:02:20 UTC 2015
- Previous message: RFR: 8074657: Missing space on a boundary of concatenated strings
- Next message: RFR: 8074657: Missing space on a boundary of concatenated strings
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Thanks Martin!
Yes, did that. I also fixed indentation in some places and replaced StringBuffer with StringBuilder.
Here's the updated webrev: http://cr.openjdk.java.net/~igerasim/8074657/01/webrev/
Sincerely yours, Ivan
On 12.05.2015 0:55, Martin Buchholz wrote:
Looks good.
(but I might go further and coalesce string constants for readability) On Mon, May 11, 2015 at 2:38 PM, Ivan Gerasimov <ivan.gerasimov at oracle.com <mailto:ivan.gerasimov at oracle.com>> wrote: Hi all! grep found a few places, where a space is missing. Would you please help review this cleanup fix? BUGURL: https://bugs.openjdk.java.net/browse/JDK-8074657 WEBREV: http://cr.openjdk.java.net/~igerasim/8074657/00/webrev/ <http://cr.openjdk.java.net/%7Eigerasim/8074657/00/webrev/> Sincerely yours, Ivan
- Previous message: RFR: 8074657: Missing space on a boundary of concatenated strings
- Next message: RFR: 8074657: Missing space on a boundary of concatenated strings
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]