RFR: 8071571: Move substring of same string to slow path (original) (raw)
Martin Buchholz martinrb at google.com
Tue May 12 17:34:08 UTC 2015
- Previous message: RFR: 8071571: Move substring of same string to slow path
- Next message: RFR: 8071571: Move substring of same string to slow path
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Ivan,
The code below looks wrong to me - sb.length() resolves to sb.count, not v2.length. If I'm correct, then there's a missing test to be added, since this error should be caught by some test.
private boolean nonSyncContentEquals(AbstractStringBuilder sb) {char v1[] = value;char v2[] = sb.getValue();
char[] v1 = value;char[] v2 = sb.getValue(); int n = v1.length;
if (n != sb.length()) {
if (n != v2.length) { return false; }
On Mon, May 11, 2015 at 1:52 PM, Ivan Gerasimov <ivan.gerasimov at oracle.com> wrote:
I have to take over this fix.
The latest webrev from the review thread above (with a few minor changes) is here: http://cr.openjdk.java.net/~igerasim/8071571/00/webrev/ Would you please review/approve the fix at your convenience? Sincerely yours, Ivan
- Previous message: RFR: 8071571: Move substring of same string to slow path
- Next message: RFR: 8071571: Move substring of same string to slow path
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]