Review request for JDK-8078596: jaxp tests failed in modular jdk due to internal class access (original) (raw)
Frank Yuan frank.yuan at oracle.com
Fri May 15 09:48:19 UTC 2015
- Previous message: JEP 254: Compact Strings
- Next message: Review request for JDK-8078596: jaxp tests failed in modular jdk due to internal class access
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi, Joe and All
This is a test bug on 9-repo-jigsaw, jaxp tests failed due to internal class access.
To fix this bug, I made the following changes:
moved the tests which test internal APIs to separate directory and added @modules for them
for other tests which don't intend to test internal APIs but have some internal API dependencies:
2.1. replaced internal APIs usage with public APIs
2.2. replaced the constants defined in internal classes with local constants
As Alan's suggestion, I would push the changes to jdk9/dev and ask an open review. Would you like to take a look? Any comment will be appreciated.
bug: https://bugs.openjdk.java.net/browse/JDK-8078596
webrev: http://cr.openjdk.java.net/~fyuan/8078596/webrev.00/
Thanks,
Frank
- Previous message: JEP 254: Compact Strings
- Next message: Review request for JDK-8078596: jaxp tests failed in modular jdk due to internal class access
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]