RFR(M, v7): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo (original) (raw)

Kim Barrett kim.barrett at oracle.com
Tue May 19 20:41:17 UTC 2015

On May 18, 2015, at 8:17 AM, Dmitry Samersoff <dmitry.samersoff at oracle.com> wrote:

Everyone, Please review updated version of the fix: http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.07/ Most important part of the fix provided by Peter Levart, so all credentials belongs to him. -Dmitry

Looks good, except a bit in Finalizer.printFinalizerQueue, specifically:

122 /* Clear stack slot containing this variable, to decrease 123 the chances of false retention with a conservative GC */ 124 referent = null;

Peter already noted these lines are mis-indented.

However I’m not convinced that assignment is actually useful, since I think it can be optimized away.

More information about the core-libs-dev mailing list