RFR 9 : 8138824 : java.lang.String: spec doesn't match impl when ignoring case (original) (raw)

RFR 9 : 8138824 : java.lang.String: spec doesn't match impl when ignoring case - equalsIgnoreCase(), regionMatches()

Brent Christian brent.christian at oracle.com
Mon Oct 12 22:52:10 UTC 2015

On 10/12/15 3:40 PM, Naoto Sato wrote:

I have two comments in the test case:

- A typo in line 32: "symetrically" -> "symmetrically"

Well-spotted. I also fixed "corresponsing" on line 78. :)

- Should "toUpperToLowerOriginals() compare the length of two strings? The current implementation returns true if str2.startsWith(str1) is true.

Yes, it also seems to me that true should only be returned if the Strings' lengths match.

Fixes will be in the pushed version.

Thanks, Naoto.

-Brent

On 10/12/15 2:44 PM, Brent Christian wrote:

FYI: updated webrev & specdiff with test case, and Roger's suggestion for using @link:

http://cr.openjdk.java.net/~bchristi/8138824/webrev.1/ http://cr.openjdk.java.net/~bchristi/8138824/specdiff.1/overview-summary.html

Thanks, -Brent On 10/8/15 10:22 AM, Brent Christian wrote: Sure, I'll write something. -B On 10/08/2015 08:57 AM, Naoto Sato wrote: Hi Brent, I wonder whether we should add a negative test case, in which lowercasing/uppercasing on the originals would differ but String.equalsIgnoreCase() returns true. Naoto On 10/7/15 4:30 PM, Brent Christian wrote: Hi,

Please review my doc/spec change (no code) for 8138824. Bug: https://bugs.openjdk.java.net/browse/JDK-8138824 Webrev: http://cr.openjdk.java.net/~bchristi/8138824/webrev.0/ Specdiff: http://cr.openjdk.java.net/~bchristi/8138824/specdiff.0/overview-summary.html

This change addresses a longstanding mismatch between spec and implementation, clarifies comparison methods which do not account for locale, and adds references to the locale-aware java.text.Collator. Thanks, -Brent

More information about the core-libs-dev mailing list