RFR 8139056: Add convenience methods to Statement.java (original) (raw)

Roger Riggs Roger.Riggs at Oracle.com
Tue Oct 20 21:33:24 UTC 2015

Hi Lance,

The logic looks correct but enquoteLiteral is going to create an lot of garbage Strings, about one for every character. I'm not sure Streams are the right tool for this task.

Can't String.replace("'", "''") do the same job?

Roger

On 10/20/2015 4:19 PM, Lance Andersen wrote:

Hi,

Looking for a reviewer for http://cr.openjdk.java.net/~lancea/8139056/webrev.00/. This change Adds two convenience methods to Statement.java: - enquoteLiteral which returns a string enclosed in single quotes where all occurrences of a single quote are converted to two single quotes - enquoteIdentifier returns a SQL identifier

The CCC has been approved. Best Lance

Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen at oracle.com

More information about the core-libs-dev mailing list