RFR: 8066644: Fix deprecation warnings in jdk.zipfs module (original) (raw)

Peter Levart peter.levart at gmail.com
Tue Oct 27 14:03:44 UTC 2015

Hi Claes,

Nice to see this getting in. Perhaps, as Aleksey notes, the conversion from epoch seconds to millis could be performed with TimeUnit?

Regards, Peter Hiall,

please review this patch which addresses deprecation warnings in jdk.zipfs module while applying the same code improvements to similar code java.util.zip.ZipUtils

webrev: http://cr.openjdk.java.net/~redestad/8066644/webrev.02 bug: https://bugs.openjdk.java.net/browse/JDK-8066644

Peter Levart brought this up and provided a patch for java.util.zip.ZipUtils earlier on this list[1], but this got delayed for various reasons. I've now included a fix to an integer overflow issue[2] since discovered in java.util.zip.ZipUtils and applied it to jdk.nio.zipfs.ZipUtils as well for consistency.

I've updated and given themicrobenchmarks a spin, verifying that the LocalDateTime version is still the fastest known approach.

/Claes

[1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-February/031714.html [2] https://bugs.openjdk.java.net/browse/JDK-8130914

More information about the core-libs-dev mailing list