RFR: 6823565: Excessive use of HandleList class in de-serialization code causes OutOfMemory (original) (raw)
Chris Hegarty chris.hegarty at oracle.com
Tue Oct 27 15:41:29 UTC 2015
- Previous message: RFR: 6823565: Excessive use of HandleList class in de-serialization code causes OutOfMemory
- Next message: RFR: 6823565: Excessive use of HandleList class in de-serialization code causes OutOfMemory
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 27 Oct 2015, at 13:56, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:
On 10/27/2015 04:51 PM, Claes Redestad wrote:
On 2015-10-27 14:21, Aleksey Shipilev wrote: On 10/25/2015 04:27 AM, Claes Redestad wrote: when deserializing objects with references to themselves, ObjectInputStream pointlessly marks the object as a dependency of itself, which increases memory required to deserialize certain memory graphs.
bug: https://bugs.openjdk.java.net/browse/JDK-6823565 webrev: http://cr.openjdk.java.net/~redestad/6823565/webrev.01/ Looks fine. A comment in markDependency should probably be updated to explain that self-referenced objects are skipped. Thanks for reviewing, Aleksey! How about "Additionally, no action is taken if the dependent and target are the same."? http://cr.openjdk.java.net/~redestad/6823565/webrev.02/
This looks good to me too.
-Chris.
Good.
Thanks, -Aleksey
- Previous message: RFR: 6823565: Excessive use of HandleList class in de-serialization code causes OutOfMemory
- Next message: RFR: 6823565: Excessive use of HandleList class in de-serialization code causes OutOfMemory
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]