RFR{S}: 8166837: [TESTBUG] Fix tests on Linux/s390x (original) (raw)

Volker Simonis volker.simonis at gmail.com
Thu Nov 3 09:45:38 UTC 2016

Looks good!

Thanks, Volker

On Thu, Nov 3, 2016 at 10:03 AM, Lindenmaier, Goetz <goetz.lindenmaier at sap.com> wrote:

Hi Volker,

I removed the two exceptions: http://cr.openjdk.java.net/~goetz/wr16/8166837-jtregfixes/jdk-wr.02 Thanks for reviewing! Best regards, Goetz

-----Original Message----- From: Volker Simonis [mailto:volker.simonis at gmail.com] Sent: Mittwoch, 2. November 2016 15:22 To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com> Cc: core-libs-dev at openjdk.java.net Subject: Re: RFR{S}: 8166837: [TESTBUG] Fix tests on Linux/s390x

Hi Goetz, the change looks good except the two throws declarations in: test/sun/tools/jhsdb/BasicLauncherTest.java test/sun/tools/jhsdb/HeapDumpTest.java I think "throws Exception" should be enough - we don't need "throws IOException, Exception". Thanks, Volker PS: we should really get rid of jdk/test/lib/testlibrary/jdk/testlibrary/Platform.java in favour of test/lib/jdk/test/lib/Platform.java. Does anybody know if there's already a bug to track that? On Wed, Nov 2, 2016 at 2:16 PM, Lindenmaier, Goetz <goetz.lindenmaier at sap.com> wrote: > Hi, > > This are the changes needed to the tests in the jdk repository > to work with s390. > In test/sun/tools/jhsdb I just use the other Platform.java which > gets it's shouldSAAttach() method changed to return 'false' on > S390. (I sent that part of the change to the hs-compiler list.) > > test/java/awt/JAWT/JAWT.sh is just skipped. > > Please review this change. > http://cr.openjdk.java.net/~goetz/wr16/8166837-jtregfixes/jdk-wr.01/ > > Best regards, > Goetz.

More information about the core-libs-dev mailing list