Request to review: JDK-8169659 (JDK-8168836 seems the wrong id) (original) (raw)
Patrick Reinhart patrick at reini.net
Wed Nov 16 10:37:05 UTC 2016
- Previous message: RFR: JDK-8168836 Minor clean up on warning/error messages
- Next message: Request to review: JDK-8169659 (JDK-8168836 seems the wrong id)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Mandy,
It seem so me I made the webrev using the wrong issue, here is the correct URL including the changes that you have suggested
http://cr.openjdk.java.net/~reinhapa/reviews/8169659/webrev.00
Sorry, for the confusion...
-Patrick
On 2016-11-15 00:20, Mandy Chung wrote:
On Nov 14, 2016, at 1:22 PM, Patrick Reinhart <patrick at reini.net> wrote:
Ups, previous mail contained wrong URL. Here’s the correct one: http://cr.openjdk.java.net/~reinhapa/reviews/8168836/webrev.00 879 log.println(getMessage("err.missing.dependences")); This should call reportError method that will prepend with “error.prefix”. So no need to have “ERROR:” in “err.missing.dependences” message. Formatting Nit: line 541-542 and line 753-754 align to the first parameter of the method. Otherwise looks good. I can sponsor it. Mandy
- Previous message: RFR: JDK-8168836 Minor clean up on warning/error messages
- Next message: Request to review: JDK-8169659 (JDK-8168836 seems the wrong id)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]