RFR[9] JDK-8158916: ProblemList.txt update for com/sun/jndi/ldap/DeadSSLLdapTimeoutTest.java (original) (raw)

Daniel Fuchs daniel.fuchs at oracle.com
Wed Nov 23 13:49:20 UTC 2016

Looks good!

On 23/11/16 05:49, John Jiang wrote:

Hi Daniel, I'll push the below patch: diff -r 5cd2aa3f3e9b test/ProblemList.txt --- a/test/ProblemList.txt Tue Nov 22 10:45:48 2016 -0800 +++ b/test/ProblemList.txt Tue Nov 22 21:34:47 2016 -0800 @@ -305,6 +305,6 @@

# jdkother -com/sun/jndi/ldap/DeadSSLLdapTimeoutTest.java 8141370 linux-i586,macosx-all +com/sun/jndi/ldap/DeadSSLLdapTimeoutTest.java 8169942 linux-i586,macosx-all,windows-x64 ############################################################################

Best regards, John Jiang On 2016/11/18 18:03, Daniel Fuchs wrote: Hi John,

Looks good to me. Should windows-amd64 also be listed? It appears the test also failing there (JDK-8152654) best regards, -- daniel On 18/11/16 06:02, John Jiang wrote: Hi, Track this test issue with a new JBS bug JDK-8169942. Please take a look at the updated webrew: http://cr.openjdk.java.net/~jjiang/8158916/webrev.01/, or the below,

--- old/test/ProblemList.txt 2016-11-17 21:29:12.112822913 -0800 +++ new/test/ProblemList.txt 2016-11-17 21:29:11.964822915 -0800 @@ -298,6 +298,6 @@ # jdkother -com/sun/jndi/ldap/DeadSSLLdapTimeoutTest.java 8141370 linux-i586,macosx-all +com/sun/jndi/ldap/DeadSSLLdapTimeoutTest.java 8169942 linux-i586,macosx-all ############################################################################

Best regards, John Jiang On 2016/11/8 18:53, Daniel Fuchs wrote: Hi John, On 08/11/16 01:30, John Jiang wrote: Hi Daniel, Thanks for your comments. On 2016/11/7 19:21, Daniel Fuchs wrote: Hi John, Maybe you should reach out to Rob who fixed JDK-8141370 to make sure this is the right thing to do. just cc Rob Mckenna

It seems the exclusion on problematic platforms [1] was deliberate: Basically I've separated the failing subtest out into its own file and excluded it on the (intermittently) failing platforms. I see. But it should use an open issue. I would like to open a new issue to track this issue. But I don't get the exact failure log on DeadSSLLdapTimeoutTest.java, though the failure may still be related to SSLHandshakeException. When this test was born, it was in the ProblemList, so I suppose it has no chance to be executed by our automatic testing systems. I see. I agree it's better to have an open bug in the ProblemList. But I am concerned if that bug is something that we never intend to fix because the test is not appropriate for those platforms. best regards, -- daniel Best regards, John Jiang best regards, -- daniel [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-December/037385.html

On 07/11/16 02:37, John Jiang wrote: Hi, com/sun/jndi/ldap/DeadSSLLdapTimeoutTest.java is associated to 8141370 in ProblemList, though issue JDK-8141370 has been resolved. In fact, the fix for JDK-8141370 extracted some codes from com/sun/jndi/ldap/LdapTimeoutTest.java to create com/sun/jndi/ldap/DeadSSLLdapTimeoutTest.java, and put the new test to ProblemList. It would be better to remove this item from ProblemList. If com/sun/jndi/ldap/DeadSSLLdapTimeoutTest.java still fails intermittently, we can put it back to ProblemList with the exact failure logs. Issue: https://bugs.openjdk.java.net/browse/JDK-8158916 Webrev: http://cr.openjdk.java.net/~jjiang/8158916/webrev.00/ Best regards, John Jiang

More information about the core-libs-dev mailing list