Request for Review and Sponsor needed: JDK-8167648: java.io.PrintWriter should have PrintWriter((String|File), Charset) constructors (original) (raw)
Roger Riggs Roger.Riggs at Oracle.com
Wed Nov 30 19:01:33 UTC 2016
- Previous message: Request for Review and Sponsor needed: JDK-8167648: java.io.PrintWriter should have PrintWriter((String|File), Charset) constructors
- Next message: Request for Review and Sponsor needed: JDK-8167648: java.io.PrintWriter should have PrintWriter((String|File), Charset) constructors
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Patrick,
I have reservations about trying to get this into JDK 9. Because it is a new API, it should have some bake time before feature freeze and it needs further review from the compatibility point of view and resources committed to create new JCK tests. Many folks are fully loaded also trying to hit feature freeze.
A few comments on the webrev:
359: The withAutoFlush javadoc should be more explicit about when a new vs the same PrintWriter is returned. The 'activates' verb doesn't convey any sense about the instance that is returned.
375: Can this use the new private constructor that will handle psOut.
-320, etc. The @since should be 1 or 2 digits to match the version scheme
no tests for new PrintWriter(OutputStream , Charset)
From the test file name 'FailngConstructors", its not clear that's
the right place for the positive tests of the withAutoFlush methods.
That's all I have time for at the moment,
Regards, Roger
On 11/29/2016 4:15 PM, Patrick Reinhart wrote:
Does anyone sponsor this fix?
http://cr.openjdk.java.net/~reinhapa/reviews/8167648/webrev.00 -Patrick
- Previous message: Request for Review and Sponsor needed: JDK-8167648: java.io.PrintWriter should have PrintWriter((String|File), Charset) constructors
- Next message: Request for Review and Sponsor needed: JDK-8167648: java.io.PrintWriter should have PrintWriter((String|File), Charset) constructors
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]