[10] RFR 8187551: MessageFormat.setFormat(int, Format) AIOOBE not thrown when documented (original) (raw)

Roger Riggs Roger.Riggs at Oracle.com
Mon Dec 4 14:57:33 UTC 2017

Hi Nishit,

Looks good,

Thanks, Roger

On 12/4/2017 1:36 AM, Nishit Jain wrote:

Thanks Roger,

Updated the webrevto add the new test case in MessageRegression.java http://cr.openjdk.java.net/~nishjain/8187551/webrev.03/ Regards, Nishit Jain On 01-12-2017 20:40, Roger Riggs wrote: Hi Nishit,

Please add the new test to test/jdk/java/text/Format/MessageFormat/MessageRegression.java instead of creating a new test. Also the convention for test names should be a functional description of the test; bug numbers are uninformative. (I'm a bit surprised there are few/no regression tests for setFormat). Thanks, Roger

On 12/1/2017 3:17 AM, Nishit Jain wrote: Hi, Please review the fix for JDK-8187551. Bug: https://bugs.openjdk.java.net/browse/JDK-8187551 Webrev: http://cr.openjdk.java.net/~nishjain/8187551/webrev.02/ Fix: As documented, updated MessageFormat.setFormat() to throw AIOOBE with invalid format element index. Thanks Martin Buchholz for filing the issue and suggesting the fix. Regards, Nishit Jain

More information about the core-libs-dev mailing list