RFR: 8193064: JarFile::getEntry0 method reference use cause for startup regression (original) (raw)

Claes Redestad claes.redestad at oracle.com
Tue Dec 5 16:25:31 UTC 2017

Hi Sherman,

sure, I'll add a small comment to this effect.

/Claes

On 2017-12-05 17:13, Xueming Shen wrote:

Hi Claes,

I'm OK with this. It would be help to add a simple comment to remind why we have to do this here, before there is better alternative in place for the startup. Thanks! Sherman On 12/5/17, 6:51 AM, Claes Redestad wrote: Hi,

desugaring the JarFileEntry::new in JarFile::getEntry0 avoids a hefty startup regression on our smallest startup tests: http://cr.openjdk.java.net/~redestad/8193064/open.00/ I think the implementation could be improved further by using static non-capturing functions rather than Jar-/ZipFileEntry::new (which, since they reference a non static class constructor, are implicitly capturing) and filed: https://bugs.openjdk.java.net/browse/JDK-8193066 Thanks! /Claes

More information about the core-libs-dev mailing list