[10?] RFR: 8193128: Reduce number of implementation classes returned by List/Set/Map.of() (original) (raw)
Claes Redestad claes.redestad at oracle.com
Wed Dec 6 22:54:22 UTC 2017
- Previous message: [10?] RFR: 8193128: Reduce number of implementation classes returned by List/Set/Map.of()
- Next message: [10?] RFR: 8193128: Reduce number of implementation classes returned by List/Set/Map.of()
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Jonathan,
On 2017-12-06 21:58, Jonathan Bluett-Duncan wrote:
Hi Claes,
Looking at http://cr.openjdk.java.net/~redestad/8193128/open.00/src/java.base/share/classes/java/util/ImmutableCollections.java.cdiff.html <http://cr.openjdk.java.net/%7Eredestad/8193128/open.00/src/java.base/share/classes/java/util/ImmutableCollections.java.cdiff.html>, there are sections labelled --- 646,657 ---- and --- 834,845 ---- where lines like
Objects.requireNonNull(0 /* zero */);are written. I believe that they were supposed to be either removed or made to be written likeObjects.requireNonNull(o /* lowercase o */). Is my belief/understanding correct?
nice catch! That was two fun little typos on my part (now why did we ever make 0 box to an Object...). Fixing in-place.
Thanks!
/Claes
- Previous message: [10?] RFR: 8193128: Reduce number of implementation classes returned by List/Set/Map.of()
- Next message: [10?] RFR: 8193128: Reduce number of implementation classes returned by List/Set/Map.of()
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]