RFR 4358774: Add null InputStream and OutputStream (original) (raw)
Brent Christian brent.christian at oracle.com
Sat Dec 9 00:50:31 UTC 2017
- Previous message: RFR 4358774: Add null InputStream and OutputStream
- Next message: RFR 4358774: Add null InputStream and OutputStream
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi, Brian
On 12/8/17 3:12 PM, Brian Burkhalter wrote:
The changes look good to me. I just noticed a couple small things in the test:
test/jdk/java/io/InputStream/NullInputStream.java
109 @Test(groups = "open") 110 public static void testreadNBytes() { 111 try { 112 assertEquals(0, openStream.readNBytes(new byte[1], 0, 1), 113 "readNBytes(byte[],int,int) != -1");
Line 113 should read "... != 0", yes?
129 @Test(groups = "open") 130 public static void testSkip() { 131 try { 132 assertEquals(0, openStream.skip(1), "transferTo() != 0");
On 132, it's "skip() != 0".
-Brent
- Previous message: RFR 4358774: Add null InputStream and OutputStream
- Next message: RFR 4358774: Add null InputStream and OutputStream
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]