RFR: JDK-8184947:,ZipCoder performance improvements (original) (raw)

Xueming Shen xueming.shen at oracle.com
Tue Dec 12 18:55:34 UTC 2017

On 12/12/2017 09:58 AM, Claes Redestad wrote:

StringCoding.java: private static void throwMalformed(int nb) { throw new IllegalArgumentException("malformed input length : " + nb); } nb is the number of bytes of the first offending chunk of bytes(?); is this information generally useful? I think the error message can be improved as input length is ambiguous in this context, but I wouldn't mind if the nb parameter was dropped along with a simplification of the error message.

It's the "copy/paste" of what MalformedInputException does for the toString(). It would/might be a help if with a "offset" info. I'm adding the offset info here with the hope it might help debugging.

Indentation errors at lines 321, 324, 728, 746, 913

updated.

TestStringCoding.java:

Are the added System.out.println's intentional? Indentation.

that's leftover of the debugging. removed.

webrev has been updated according. I believe Martin is also reviewing.

Thanks! Sherman

More information about the core-libs-dev mailing list