RFR of 8180451: ByteArrayInputStream should override readAllBytes, readNBytes, and transferTo (original) (raw)

Brent Christian brent.christian at oracle.com
Tue Dec 12 20:23:51 UTC 2017

• Previous message: RFR of 8180451: ByteArrayInputStream should override readAllBytes, readNBytes, and transferTo
• Next message: RFR(JDK10/JAXP) 8190823: Broken link in org/w3c/dom/ls/
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi, Brian

The changes look fine to me. I would have found the test case a little easier to follow if "off"/"len" weren't named so similarly to "offset"/"length", but it's not a big deal.

-Brent

On 12/11/17 12:47 PM, Brian Burkhalter wrote:

https://bugs.openjdk.java.net/browse/JDK-8180451 http://cr.openjdk.java.net/~bpb/8180451/webrev.00

1. Add overrides of readAllBytes(), readNBytes(), and transferTo(). 2. Simplify parameter checks in read(byte[],int,int). 3. Change foo to {@code foo}. Thanks, Brian

• Previous message: RFR of 8180451: ByteArrayInputStream should override readAllBytes, readNBytes, and transferTo
• Next message: RFR(JDK10/JAXP) 8190823: Broken link in org/w3c/dom/ls/
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the core-libs-dev mailing list