RFR JDK-8193479: test/hotspot/jtreg/compiler/codegen/Test6896617.java fails after JDK-8184947 (original) (raw)

Xueming Shen xueming.shen at oracle.com
Thu Dec 14 02:05:22 UTC 2017

David, Martin,

webrev has been updated to fix the test directly.

http://cr.openjdk.java.net/~sherman/8193479/webrev

Assume I would need hotspot guys' help to review and push into hs repo?

thanks, Sherman

On 12/13/17, 4:52 PM, Martin Buchholz wrote:

It would add more confusion to a something that's already difficult to understand. It's OK as a temporary measure, but I don't think we want product code just to enable tests in hotspot. Can the hotspot folks modify their test, perhaps making this code part of the test?

On Wed, Dec 13, 2017 at 4:01 PM, Xueming Shen <xueming.shen at oracle.com_ _<mailto:xueming.shen at oracle.com>> wrote: Hi Please help review the change for JDK-8193479 issue: https://bugs.openjdk.java.net/browse/JDK-8193479 <https://bugs.openjdk.java.net/browse/JDK-8193479> webrev: http://cr.openjdk.java.net/~sherman/8193479/webrev <http://cr.openjdk.java.net/%7Esherman/8193479/webrev> The internal interface ArrayEn/Decoder for ISO88591 has been removed because it is no longer used by StringCoding class, but it appears it is being used by hotspot Test6896617.java to verify the SSE instructions on x86. The proposed change here is to simply restore the internal interface ArrayEn/Decoder for ISO88591 to avoid blocking hotspot testing for now. thanks, Sherman

More information about the core-libs-dev mailing list