[11] RFR 8193085 Vectorize the nio Buffer equals and compareTo implementations (original) (raw)
Paul Sandoz paul.sandoz at oracle.com
Fri Dec 15 22:21:45 UTC 2017
- Previous message: [11] RFR 8193085 Vectorize the nio Buffer equals and compareTo implementations
- Next message: [11] RFR 8193085 Vectorize the nio Buffer equals and compareTo implementations
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 15 Dec 2017, at 13:01, David Lloyd <david.lloyd at redhat.com> wrote:
I'm not a reviewer, but I was curious about this change; unfortunately the diff seems to be dominated by case and formatting changes making the actual functional aspect change hard to divine.
If not already i recommend viewing via udiffs, i find that makes it easier.
Within the JBoss unit we have an informal policy that formatting changes should be presented separately so that it's easier to trace back problems in the future, as well as being much easier to review the change in the first place. Would I be stepping out of bounds to suggest that this change should be similarly divided?
In hindsight :-) at this point i would prefer not to split it unless reviewers are having a really hard time. I was furiously hacking on this and got fed up with the names making it harder for me to reason about the code so i changed ‘em mid-flight when doing this work.
Thanks, Paul.
- Previous message: [11] RFR 8193085 Vectorize the nio Buffer equals and compareTo implementations
- Next message: [11] RFR 8193085 Vectorize the nio Buffer equals and compareTo implementations
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]