[11] RFR of 8146656: Wrong Months Array for DateFormatSymbols (original) (raw)

joe darcy joe.darcy at oracle.com
Tue Dec 19 09:25:21 UTC 2017

Hi Rachna,

On 12/19/2017 1:13 AM, Rachna Goel wrote:

Hello Joe, Thanks for the review. Reason I added @implNote is that it's the case for the default implementation. Not added as a part of spec, as some implementation can just return 12 element array for same methods through the "java.text.spi.DateFormatSymbolsProvider" SPI.

That is precisely the sort of situation the @implSpec tag is intended for. It allows the specification to say DateFormatSymbols must behave this way while allowing subclasses to behave differently.

Perhaps some general text can be added as normal specification, something like

"An array with either 12 or 13 elements will be returned depending on whether or {@link Calendar.UNDECIMBER} is supported."

paired with

@implSpec This method returns 13 elements since @link Calendar.UNDECIMBER} is supported.

HTH,

-Joe

More information about the core-libs-dev mailing list