RFR [11] JDK-8179424: Remove terminally deprecated sun.reflect.Reflection.getCallerClass (original) (raw)

David Holmes david.holmes at oracle.com
Thu Dec 21 12:33:36 UTC 2017

On 21/12/2017 8:20 PM, Chris Hegarty wrote:

David, Alan,

On 21 Dec 2017, at 09:54, Alan Bateman <Alan.Bateman at oracle.com> wrote:

On 21/12/2017 09:29, David Holmes wrote: :

Updated webrev: http://cr.openjdk.java.net/~chegar/8179424/webrev.02/ I don't quite follow the change to the langtools test. Is it just trying to reference something in jdk.unsupported? I don't know what the "patch" does. I looked through webrev.02 and it looks okay. I assume there will be a follow-up bug created to re-examine JVMGetCallerClass. The update to the jdeps test does look a bit odd, wouldn't it be better to change it to another internal API? The test is about identifying StackWalker as the replacement supported API for getCallerClass, which is continues to do.

Won't pretend I actually understand that, but as long as the test works reliably then okay.

Thanks, David

I could add yet another scenario to test for a different internal API that also has a replacement, and add the appropriate @modules to the test to expose its package.

-Chris.

More information about the core-libs-dev mailing list