[12] (AIX) 8207744: Clean up inconsistent use of opendir/closedir versus opendir64/closedir64 (original) (raw)

Brian Burkhalter brian.burkhalter at oracle.com
Fri Aug 3 22:08:25 UTC 2018

HI Matthias,

I think I fixed the dirent problem: thanks for pointing it out.

http://cr.openjdk.java.net/~bpb/8207744/webrev.03/

The usual builds passed and tests are running.

I think that there is some _ALLBSD_SOURCE cruft in UnixNativeDispatcher.c which could be cleaned up but we’ll leave that for another day.

Thanks,

Brian

On Aug 2, 2018, at 11:57 PM, Baesken, Matthias <matthias.baesken at sap.com> wrote:

looks like the function

struct dirent64 *readdir64 (DIR64 *DirectoryPointer); returns dirent64* ( according to https://www.ibm.com/support/knowledgecenter/no/sswaix72/com.ibm.aix.basetrf1/opendir.htm ) and some of the files below still have dirent* on AIX ( at some places it is redefined ). For example : http://cr.openjdk.java.net/~bpb/8207744/webrev.02/src/java.base/unix/native/libjava/ProcessHandleImplunix.c.frames.html 508 jint unixgetChildren(JNIEnv *env, jlong jpid, jlongArray jarray, 509 jlongArray jparentArray, jlongArray jstimesArray) { 510 DIR* dir; 511 struct dirent* ptr;

Not sure if this is really an issue in “real life” ….

More information about the core-libs-dev mailing list