[RFR] 8205525 : Improve exception messages during manifest parsing of jar archives (original) (raw)

Chris Hegarty chris.hegarty at oracle.com
Thu Aug 9 09:02:28 UTC 2018

Matthias,

On 9 Aug 2018, at 08:07, Baesken, Matthias <matthias.baesken at sap.com> wrote:

Did we get to a conclusion on whether to have central infrastructure to read/parse the security property? As I recall, this one was originally proposed before the generalization of the networking solution. There are details related to trimming that would be better not to duplicate if possible. Hi Alan / Chris , I am aware of https://bugs.openjdk.java.net/browse/JDK-8207846 where jdk.net.includeInExceptions has been generalized to be used for other use cases than exceptions in the networking area . This has been pushed in the meantine. Could you point me to the other discussion, is there already a webrev posted for this ?

Given that 8207846 was being targeted to JDK 11, during RDP 1, it was decided to keep the changes as minimal as possible. The supporting implementation, that reads and parses the property, remains in src/java.base/share/classes/sun/net/util/SocketExceptions.java. Alan referred to this in one of the review comments for 8207846 [1]. If this mechanism is to be used outside of the networking area, and I think it can, then the implementation in SocketExceptions should probably be moved to some other more appropriate internal package.

Also, I think one of my comments on the original patch is that we should get the style and line lengths a bit more consistent with the existing code (the patch added excessively long lines for example). Sure I'll look into it !

-Chris.

[1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-July/054501.html

Best regards, Matthias

-----Original Message----- From: Alan Bateman <Alan.Bateman at oracle.com> Sent: Mittwoch, 8. August 2018 20:30 To: Baesken, Matthias <matthias.baesken at sap.com>; Chris Hegarty <chris.hegarty at oracle.com> Cc: core-libs-dev at openjdk.java.net; Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; Langer, Christoph <christoph.langer at sap.com>; OpenJDK Dev list <security-_ _dev at openjdk.java.net> Subject: Re: [RFR] 8205525 : Improve exception messages during manifest parsing of jar archives On 07/08/2018 16:00, Baesken, Matthias wrote: Ping .... �� , any reviews / comments ? Did we get to a conclusion on whether to have central infrastructure to read/parse the security property? As I recall, this one was originally proposed before the generalization of the networking solution. There are details related to trimming that would be better not to duplicate if possible. Also, I think one of my comments on the original patch is that we should get the style and line lengths a bit more consistent with the existing code (the patch added excessively long lines for example). -Alan.

More information about the core-libs-dev mailing list