RFR: 8209120: Archive the Integer.IntegerCache (original) (raw)

Ioi Lam ioi.lam at oracle.com
Fri Aug 10 15:52:31 UTC 2018

On 8/10/18 8:44 AM, Claes Redestad wrote:

On 2018-08-10 16:10, Ioi Lam wrote:

I've verified all cases I can think of manually, but would like to defer the creation of a sanity test to a follow-up RFE to allow time to think through and discussing how to best go about that (do we need to verify in depth, can we reuse some existing test etc..)

I think it’s better to include a good test case in this REF, especially since object archiving is a new feature. Well, I'm not sure about "good", but I have a test case I've tinkered with that simply tests that identity of Integer.valueOf behaves as expected w.r.t. Object identity around the break-off point. I'm pondering if we need to inspect the archived values more deeply, but perhaps it's good enough as a sanity test for now: http://cr.openjdk.java.net/~redestad/8209120/open.02/ WDYT? Hi Claes,

Thanks for writing these tests. They look "good" to me :-).

If I understand Peter's comments correctly, the main concern is that the runtime configurations may be different than what you have at dump time. These tests seem to sufficiently cover such differences.

Thanks

/Claes

More information about the core-libs-dev mailing list