RFR:8205330 InitialDirContext ctor sometimes throws NPE if the server has sent a disconnection (original) (raw)
Chris Hegarty chris.hegarty at oracle.com
Fri Aug 24 15:22:44 UTC 2018
- Previous message: RFR:8205330 InitialDirContext ctor sometimes throws NPE if the server has sent a disconnection
- Next message: RFR - CSR JDK-8200435 - String::align, String::indent (after revisions)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Vyom,
On 24/08/18 11:35, vyom tewari wrote:
Hi All,
Please review this simple fix below webrev: http://cr.openjdk.java.net/~vtewari/8205330/webrev0.0/index.html bugid: https://bugs.openjdk.java.net/browse/JDK-8205330 This fix will resolve the race in LdapClient where we are explicitly making "null" to LdapClient.conn.
Sorry, I don't know this code all that well, but I think that more explanation will be needed before this code can be reviewed.
The LdapClient and the Connection seem to be loosely
coupled. I think part of this is to allow the LdapClient
to be GC'ed and finalized separately to the Connection
( that can be reused ). Not setting conn to null could
have a negative impact on this loose coupling. I also
note that the synchronization is implemented poorly in
the LdapClient, conn is operated on both from within
synchronized blocks and from unsynchronized blocks (
which I think is the reason you see the unexpected
null ).
-Chris.
- Previous message: RFR:8205330 InitialDirContext ctor sometimes throws NPE if the server has sent a disconnection
- Next message: RFR - CSR JDK-8200435 - String::align, String::indent (after revisions)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]