RFR JDK-8209786: gcc 7.3 compiler errors on zLinux (original) (raw)

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Thu Aug 30 14:36:28 UTC 2018

Hi Leonard,

the change looks good to me. I'll test it tonight, to make sure it runs with our compilers. Did you run it through jdk-submit?

If you supply a patch with all the changeset information (like from hg export) that jchecks fine, I'll sponsor this for you.

Best regards, Goetz.

-----Original Message----- From: core-libs-dev <core-libs-dev-bounces at openjdk.java.net> On Behalf Of Andrew Leonard Sent: Donnerstag, 30. August 2018 14:19 To: Brian Burkhalter <brian.burkhalter at oracle.com> Cc: core-libs-dev at openjdk.java.net Subject: Re: RFR JDK-8209786: gcc 7.3 compiler errors on zLinux

Hi Brian, Thanks for taking a look at this, I have just done a rebuild with a new patch with appropriate gcc disable warnings for these libraries: http://cr.openjdk.java.net/~aleonard/8209786/webrev.01/ This works fine, so if you think this is a more favourable approach for these libraries? i'd like to get this merged please. Thanks Andrew Andrew Leonard Java Runtimes Development IBM Hursley IBM United Kingdom Ltd Phone internal: 245913, external: 01962 815913 internet email: andrewmleonard at uk.ibm.com

From: Brian Burkhalter <brian.burkhalter at oracle.com> To: Andrew Leonard <andrewmleonard at uk.ibm.com> Cc: core-libs-dev at openjdk.java.net Date: 28/08/2018 15:52 Subject: Re: RFR JDK-8209786: gcc 7.3 compiler errors on zLinux Hi Andrew, It was suggested that it would be preferable to dial down the compilation settings for the fdlibm code rather than make a source code change. Was this investigated? Thanks, Brian On Aug 28, 2018, at 7:18 AM, Andrew Leonard <andrewmleonard at uk.ibm.com> wrote: We have discovered issues with gcc 7.3 on zLinux, combined with OpenJDK's default compiler options has highlighted a couple of native code issues, with undefined behaviours: - validating loop test array bounds - left shifts of negative values I have created bug https://bugs.openjdk.java.net/browse/JDK-8209786 and attached the webrev fix here: http://cr.openjdk.java.net/~aleonard/8209786/webrev.00/ This has already been discussed and refined on the "s390x-port-dev" maillist and as it was pointed out, it should have been posted here... I'd like to request a sponsor for this fix please? Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

More information about the core-libs-dev mailing list