[12] RFR 8209773: Refactor shell test javax/naming/module/basic.sh to java (original) (raw)

Chris Yin xu.y.yin at oracle.com
Fri Aug 31 01:07:48 UTC 2018


Thank you, Vyom

Regards, Chris

On 30 Aug 2018, at 5:06 PM, vyom tewari <vyom.tewari at oracle.com> wrote:

Hi Chris, The refactored java class (RunBasic.java) looks good to me. Thanks, Vyom

On Tuesday 28 August 2018 11:20 AM, Chris Yin wrote: Please have a review for below change to refactor shell test javax/naming/module/basic.sh to plain java, no test logic change, old shell script is removed at same time, thanks

bug: https://bugs.openjdk.java.net/browse/JDK-8209773 webrev: http://cr.openjdk.java.net/~xyin/8209773/webrev.00/ Regards, Chris



More information about the core-libs-dev mailing list