RFR: 8134459: java/util/stream/test/org/openjdk/tests/java/util/stream/WhileOpTest.java timed out (original) (raw)
Claes Redestad claes.redestad at oracle.com
Tue Jan 9 22:55:37 UTC 2018
- Previous message: RFR: 8134459: java/util/stream/test/org/openjdk/tests/java/util/stream/WhileOpTest.java timed out
- Next message: RFR: 8134459: java/util/stream/test/org/openjdk/tests/java/util/stream/WhileOpTest.java timed out
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Paul,
On 2018-01-09 23:23, Paul Sandoz wrote:
This might also improve other tests using the same assert.
Not unlikely.
LambdaTestHelpers -- s/if(/if ( + int i = -1; + while (actual.hasNext() && expected.hasNext()) { + i++; + Object e = expected.next(); + Object a = actual.next(); + assertEquals(a, e, "Iterators differ"); + + }
‘i' is redundant. I presume might have wanted to use it to print out the index on element assertion failure, but it would of course induce garbage.
Fixed in place
/Claes
- Previous message: RFR: 8134459: java/util/stream/test/org/openjdk/tests/java/util/stream/WhileOpTest.java timed out
- Next message: RFR: 8134459: java/util/stream/test/org/openjdk/tests/java/util/stream/WhileOpTest.java timed out
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]