RFR: 8194287 and 8194286: simple test changes for the execution of these tests in a docket container (original) (raw)
Kumar Srinivasan kumar.x.srinivasan at oracle.com
Fri Jan 12 15:42:00 UTC 2018
- Previous message: RFR: 8194287 and 8194286: simple test changes for the execution of these tests in a docket container
- Next message: RFR: 8194287 and 8194286: simple test changes for the execution of these tests in a docket container
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Roger,
Thanks for looking at this.
Hi Kumar,
RunPathTest should say what is missing from the environment to skip the test. Otherwise, the curious has to go back a read the code to figure it out.
Actually it does say what is missing, however it will be printed before this message.
webrev does not quite make this clear as it gobbles up areas of the source files which have are not changed, please see this line, it will become apparent.
http://cr.openjdk.java.net/~ksrini/8194287/webrev-00/test/jdk/tools/launcher/RunpathTest.java.html
line 52
Thanks Kumar
Thanks, Roger
On 1/11/2018 6:00 PM, Kumar Srinivasan wrote: Hi,
Please review bug fixes for 2 test bugs, which fails with a base Linux installation in a docker container. Thanks Kumar [1] http://cr.openjdk.java.net/~ksrini/8194287/webrev-00/ [2] http://cr.openjdk.java.net/~ksrini/8194287/cmt.txt
- Previous message: RFR: 8194287 and 8194286: simple test changes for the execution of these tests in a docket container
- Next message: RFR: 8194287 and 8194286: simple test changes for the execution of these tests in a docket container
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]